fix: resolve the issue of text editing not being effective before the table #5365
Conversation
f2c-ci-robot
bot
added
kind/bug
f2c-ci-robot
bot
added
the
area/console
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5365 +/- ##
============================================
- Coverage 56.91% 56.90% -0.01%
+ Complexity 3319 3315 -4
============================================
Files 587 587
Lines 18968 18953 -15
Branches 1401 1399 -2
============================================
- Hits 10795 10785 -10
+ Misses 7594 7588 -6
- Partials 579 580 +1 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-2.12 |
|
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
f2c-ci-robot
bot
added
the
approved
|
/ping @halo-dev/sig-halo |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@LIlGG: new pull request created: #5378 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area editor
/area console
What this PR does / why we need it:
在 #5191 中对表格新增了如果可以左右滚动时，则显示阴影的特性。而根据
prosemirror的数据流处理策略，在decorations中，state 是 new EditorState，但通过this.editor.view获取到的 view 为 old EditorView，进而导致使用了最新的坐标，并且使用其坐标通过旧版本的 view 中获取 DOM 而产生的错误。本 PR 使用
NodeView而不是decorations来重新处理表格阴影。How to test it?
在默认富文本编辑器中新建一个表格。在表格前使用拼音输入文本，查看此文本能否被输入。
同时查看表格阴影是否存在
Which issue(s) this PR fixes:
Fixes #5352
Does this PR introduce a user-facing change?